Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devops: Clean up PR Template on Github #172

Open
Yoshi275 opened this issue Jan 29, 2020 · 0 comments
Open

devops: Clean up PR Template on Github #172

Yoshi275 opened this issue Jan 29, 2020 · 0 comments
Labels
better engineering documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Yoshi275
Copy link
Contributor

Since we don't do unit testing for now, it'll be good if the PR can specify how reviewers can test code automatically. Eg. Test out on local system or try Netlify preview on the PR itself, and delete the unit testing section.

Will be good to remind people to use Github markdown keywords to conveniently link the issue to the PR and close when PR is merged!
https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords
@Yoshi275 Yoshi275 added documentation Improvements or additions to documentation better engineering good first issue Good for newcomers labels Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
better engineering documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Yoshi275