Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download queued FFIS spreadsheets to S3 #11

Closed
TylerHendrickson opened this issue Feb 2, 2023 · 2 comments · Fixed by #73
Closed

Download queued FFIS spreadsheets to S3 #11

TylerHendrickson opened this issue Feb 2, 2023 · 2 comments · Fixed by #73
Assignees
Labels
enhancement New feature or request Grant Finder

Comments

@TylerHendrickson
Copy link
Member

TylerHendrickson commented Feb 2, 2023

DOD: When a message containing a URL for an FFIS spreadsheet is sent to the "FFIS Downlaods" SQS queue, the spreadsheet file that the URL points to is saved to the "Grants Source Data" S3 bucket.

Blockers:

Implementation details:

  • Create a "Download FFIS Spreadsheet" Lambda function that:
    • Sources invocation events from the "FFIS Downloads" SQS queue
    • When invoked, uses the URL from the SQS message in the invocation event to download the file at that URL.
    • Uses the download stream in order to upload the file as a new object in the "Grants Source Data" S3 bucket, with an object key prefix of /sources/YYYY/mm/dd/ffis/download.xlsx.
@TylerHendrickson TylerHendrickson added the enhancement New feature or request label Feb 2, 2023
@TylerHendrickson TylerHendrickson transferred this issue from usdigitalresponse/usdr-gost Mar 21, 2023
@TylerHendrickson TylerHendrickson moved this from 🔩 Eng planning to 📋 Backlog in Grants Team Agile Planning Mar 27, 2023
@TylerHendrickson TylerHendrickson moved this from 📋 Backlog to 🔖 Ready in Grants Team Agile Planning Apr 28, 2023
@jakekreider jakekreider self-assigned this Apr 28, 2023
@jakekreider jakekreider moved this from 🔖 Ready to 🏗 In progress in Grants Team Agile Planning Apr 30, 2023
@jakekreider
Copy link
Contributor

@TylerHendrickson What do you expect the /YYYY/mm/dd portion of the object key prefix to come from- the time of invocation of the Lambda, or copied from the path of the source email read by EnqueueFFISDownloads?

@TylerHendrickson
Copy link
Member Author

TylerHendrickson commented Apr 30, 2023

@TylerHendrickson What do you expect the /YYYY/mm/dd portion of the object key prefix to come from- the time of invocation of the Lambda, or copied from the path of the source email read by EnqueueFFISDownloads?

@jakekreider The date-based object key path components are meant to reference the revision date of the data stored at that particular path. So in this case, we should copy the path of the source email, which represents the date we received the digest. Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Grant Finder
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants