-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include last point in downsampling #231
base: develop
Are you sure you want to change the base?
Conversation
carma_ros2_utils/include/carma_ros2_utils/containers/containers.hpp
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Currently I am trying to reproduce the error where I could meaningfully test this change. |
This needs more integration testing as I see weird trajectory being generated from inlanecruising. Possibly due to overlapping points the spline fit is curving. |
Dismissing review due to additional integration testing being required per Misheel's recent comment.
PR Details
Description
Original issue is described well in the Github Issue.
Solution proposed here is to include the last point in the lanelet no matter the downsampling size, so that every lanelet's downsampling still has correct boundaries.
This would also fix cases where if lanelet is too small to be downsampled, it would still return at least 2 trajectory points which should be enough to fit spline.
Related GitHub Issue
usdot-fhwa-stol/carma-platform#2343
Related Jira Key
https://usdot-carma.atlassian.net/browse/CAR-6038
Motivation and Context
Discovered during VRU use case validation testing data analysis
How Has This Been Tested?
unit tested and integration testing on sim pc 1 in progress
Types of changes
Checklist: