Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include last point in downsampling #231

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Jun 3, 2024

PR Details

Description

Original issue is described well in the Github Issue.
Solution proposed here is to include the last point in the lanelet no matter the downsampling size, so that every lanelet's downsampling still has correct boundaries.
This would also fix cases where if lanelet is too small to be downsampled, it would still return at least 2 trajectory points which should be enough to fit spline.

Related GitHub Issue

usdot-fhwa-stol/carma-platform#2343

Related Jira Key

https://usdot-carma.atlassian.net/browse/CAR-6038

Motivation and Context

Discovered during VRU use case validation testing data analysis

How Has This Been Tested?

unit tested and integration testing on sim pc 1 in progress

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN added the bug Something isn't working label Jun 3, 2024
@MishkaMN MishkaMN requested a review from JonSmet June 3, 2024 17:01
@MishkaMN MishkaMN self-assigned this Jun 3, 2024
@MishkaMN MishkaMN requested a review from JonSmet June 6, 2024 20:21
JonSmet
JonSmet previously approved these changes Jun 6, 2024
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MishkaMN
Copy link
Contributor Author

Currently I am trying to reproduce the error where I could meaningfully test this change.
And also make sure I am not breaking anything existing. I have other higher priority stories taking over that is pushing this behind a little bit

@MishkaMN
Copy link
Contributor Author

This needs more integration testing as I see weird trajectory being generated from inlanecruising. Possibly due to overlapping points the spline fit is curving.

@MishkaMN MishkaMN marked this pull request as draft June 12, 2024 14:57
@JonSmet JonSmet dismissed their stale review June 21, 2024 15:20

Dismissing review due to additional integration testing being required per Misheel's recent comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants