Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DOCKER_SHARED_VOLUME_WINDOWS Environmental Variable #517

Closed
2 tasks
Michael7371 opened this issue Aug 24, 2023 · 5 comments
Closed
2 tasks

Remove DOCKER_SHARED_VOLUME_WINDOWS Environmental Variable #517

Michael7371 opened this issue Aug 24, 2023 · 5 comments

Comments

@Michael7371
Copy link
Contributor

Types of Issue

  • Anomaly report (something appears to not work correctly)
  • [ x ] Enhancement request (describe the enhancement being requested)
  • Other (please ensure the description clarifies why the issue doesn’t fall into either of the above categories)

Descriptive summary

Remove the environmental variable DOCKER_SHARED_VOLUME_WINDOWS as it no longer seems required for Windows users.

ODE version where this issue was discovered

1.4.0

Expected behavior

The volume attached to Kafka to be the same volume as the volume used for other services.

Actual behavior

Volume is different and throws errors if DOCKER_SHARED_VOLUME_WINDOWS is set to "c:".

Steps to reproduce the actual behavior

When set to "C:" a docker build fails to build when using WSL Ubuntu shell. If building using Powershell either "C:" or an empty field works.

Related work

#515

@paulbourelly999
Copy link
Contributor

@Michael7371 Can we close this issue if the fix is merged or is the plan to eventually remove the environment variable entirely?

@Michael7371
Copy link
Contributor Author

Michael7371 commented Aug 30, 2023

@paulbourelly999 This issue is for removing the variable entirely. I believe this variable was made when Docker for Windows lacked WSL support and required different path settings.

@dmccoystephenson
Copy link
Collaborator

Has this been done yet? @Michael7371

@Michael7371
Copy link
Contributor Author

@dmccoystephenson No it has not.

@drewjj
Copy link
Collaborator

drewjj commented Feb 5, 2024

This issue has been resolved with #515

@drewjj drewjj closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants