Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installed wasm-opt optimization not working #183

Closed
ascjones opened this issue Feb 18, 2021 · 3 comments · Fixed by #187
Closed

Installed wasm-opt optimization not working #183

ascjones opened this issue Feb 18, 2021 · 3 comments · Fixed by #187
Assignees
@cmichi

Comments

@ascjones
Copy link
Collaborator

ascjones commented Feb 18, 2021 •
edited
Loading

Using locally installed wasm-opt version 99 (version_73-1265-ga74bc72db)

image

Discovered while testing #174, but it is also an issue on master (I did pull the latest this time!).

Possibly related to #179, but haven't done any troubleshooting yet.
@cmichi
Copy link
Collaborator

cmichi commented Feb 18, 2021 •
edited
Loading

Edit: This is most likely an issue with a regression in wasm-opt. My local version was built with WebAssembly/binaryen@9c5df06 and returns an optimized flipper of 2.5k.

@ascjones
Copy link
Collaborator Author

Built with WebAssembly/binaryen@f7bfc85 which is the current HEAD

@cmichi
Copy link
Collaborator

cmichi commented Feb 19, 2021

I've created WebAssembly/binaryen#3587.

@cmichi cmichi self-assigned this Feb 19, 2021
@cmichi cmichi mentioned this issue Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmichi cmichi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wasm-opt regression use-ink/cargo-contract
2 participants
@ascjones @cmichi