Make constructors (non)payable

[athei]

When paritytech/substrate#10082 is merged there is no longer a need to pass an endowment larger than 0 except when the contract logic itself requires it. This makes endowment no different from value in a call extrinsic.

Therefore I think we should extend the payable logic to constructors. The UI can then remove the endowment field for non payable constructors.

[Robbepop]

Can you elaborate on this a bit?
So will it be possible to have value and endownment fields upon contract instantiation?
Currently in ink! all constructors are implicitly payable since unpayable constructors make no sense since the contract would be evicted immediately after.

[athei]

So will it be possible to have value and endownment fields upon contract instantiation?

No, there is still only endowment.

Currently in ink! all constructors are implicitly payable since unpayable constructors make no sense since the contract would be evicted immediately after.

And this is exactly the part that is about to change soon. Unpayable constructors make sense then.

[Robbepop]

So should we non-confusingly rename this issue to "Allow ink! constructors to be non-payable" ?

[athei]

Sure, if that makes more sense to you. The issue is about allowing this payable attribute there which is now set by default.

[athei]

Needs to be done before the stable release because it is a breaking change.