Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of "legacy" inline events #2046

Open
SkymanOne opened this issue Jan 5, 2024 · 1 comment
Open

Deprecation of "legacy" inline events #2046

SkymanOne opened this issue Jan 5, 2024 · 1 comment
Labels
A-ink_lang [ink_lang] Work item C-discussion An issue for discussion for a given topic.

Comments

@SkymanOne
Copy link
Contributor

Follow up for #1827 and related to #2031

Since the introduction of the shared event definition and the potential addition of the custom signature topic, it was realised that we need to maintain two sets of macros that serve identical purposes: legacy inline macros and new shared events.

Technically, the former can be achieved by the latter. Therefore, it is suggested to remove legacy inline events in favour of shared event definition. We have two ways of how to proceed:

  1. Remove them now for the stable ink! 5.0.0 release
  2. Keep them In 5.0.0, but add a deprecation notice and remove them in ink! 6.0.0. This would provide a smooth transition and time for the ecosystem to update docs and examples.
  3. Keep inline events and maintain them alongside shared event definition
@SkymanOne SkymanOne added C-discussion An issue for discussion for a given topic. A-ink_lang [ink_lang] Work item labels Jan 5, 2024
@SkymanOne SkymanOne mentioned this issue Jan 6, 2024
5 tasks
@ascjones
Copy link
Collaborator

ascjones commented Jan 8, 2024

For 2. we don't need to add the deprecation notice for 5.0, we can do it in a 5.x release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ink_lang [ink_lang] Work item C-discussion An issue for discussion for a given topic.
Projects
None yet
Development

No branches or pull requests

2 participants