Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): deprecate --provider-url for --rpc-url #1242

Merged
merged 20 commits into from
Aug 22, 2024

Conversation

saeta-eth
Copy link
Contributor

@saeta-eth saeta-eth commented Aug 7, 2024

This PR aims to deprecate --provider-url in favor of --rpc-url. If users use --provider-url, it will work but will display a warning message about the deprecation.

Screenshot 2024-08-12 at 6 53 08 PM

Closes https://linear.app/usecannon/issue/CAN-427/deprecate-provider-url-for-rpc-url

Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: 1463fed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1463fed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@saeta-eth saeta-eth marked this pull request as ready for review August 12, 2024 22:02
@saeta-eth saeta-eth merged commit f675677 into main Aug 22, 2024
7 of 9 checks passed
@saeta-eth saeta-eth deleted the feat/deprecate-provider-url branch August 22, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants