Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): cannon diff command #1261

Merged
merged 10 commits into from
Aug 23, 2024
Merged

feat(cli): cannon diff command #1261

merged 10 commits into from
Aug 23, 2024

Conversation

dbeal-eth
Copy link
Contributor

@dbeal-eth dbeal-eth commented Aug 14, 2024

Closes https://linear.app/usecannon/issue/CAN-442/cannon-diff-command-for-validating-contracts-on-project-match-a

this command allows for comparing aspects of cannon state with things.

for the time being, this PR focuses on comparing the cannon state contracts with the ones in a foundry project, highlighting any differences.

notes:

  • its possible to filter contracts to compare and source files to compare using the provided options
  • exit code matches the nubmer of "differences" found, so only successful output is no diffs (usually what people are checkign for)
  • we could do something very similar to hardhat, but lets wait to see how the current impl works with stakeholders

@dbeal-eth dbeal-eth added the enhancement New feature or request label Aug 14, 2024
@dbeal-eth dbeal-eth self-assigned this Aug 14, 2024
Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 56afd71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 56afd71. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@dbeal-eth dbeal-eth changed the title cannon diff command feat(cli): cannon diff command Aug 14, 2024
dbeal-eth and others added 5 commits August 14, 2024 16:53
this command allows for comparing aspects of cannon state with things.

for the time being, this PR focuses on comparing the cannon state contracts with the ones in a foundry project, highlighting any differences.

notes:
* its possible to filter contracts to compare and source files to compare using the provided options
* exit code matches the nubmer of "differences" found, so only successful output is no diffs (usually what people are checkign for)
* we could do something very similar to hardhat, but lets wait to see how the current impl works with stakeholders
Co-authored-by: Matías <mjlescano@users.noreply.github.com>
@saeta-eth saeta-eth enabled auto-merge (squash) August 23, 2024 22:16
@saeta-eth saeta-eth merged commit c9d3dc6 into main Aug 23, 2024
7 of 9 checks passed
@saeta-eth saeta-eth deleted the cannon-diff branch August 23, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants