Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builder): add immutable capability to diamond proxy #1281

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

dbeal-eth
Copy link
Contributor

also fixes a few edge cases and cleans some stuff up

fixes https://linear.app/usecannon/issue/CAN-430/add-immutable-prop-to-diamond-proxy-step

@dbeal-eth dbeal-eth self-assigned this Aug 16, 2024
Copy link

changeset-bot bot commented Aug 16, 2024

⚠️ No Changeset found

Latest commit: fb7340f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fb7340f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@dbeal-eth dbeal-eth changed the title add immutable capability to diamond proxy feat(builder): add immutable capability to diamond proxy Aug 25, 2024
@dbeal-eth dbeal-eth enabled auto-merge (squash) August 25, 2024 08:47
@dbeal-eth dbeal-eth merged commit f67007a into main Aug 25, 2024
7 of 9 checks passed
@dbeal-eth dbeal-eth deleted the immutable-diamond branch August 25, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants