-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Fix parse error on undefined values in tuples #1285
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1b4ff6c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
When decoding tuples, the whole struct being decoded is passed as an object inside of an array containing the values of the struct, the decode function attempts to parse this as an array when it should be parsing tuple values as objects this was causing an error when trying to parse these values and they were returning undefined.
Also added names to the values inside of a tuple to make it more clear
Before:
After:
Note: For the feed id below, the bytes32 value does not get parsed correctly and returns garbled output
fixes https://linear.app/usecannon/issue/CAN-437/decode-command-does-not-work-with-tuples