Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): CAN-488 Show package code when diff can't be shown. #1288

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Aug 17, 2024

Closes #CAN-488.

Currently, On the deploy page, if we can not show diff in the package file, we do not show the package code.

This PR shows the package code even though we can not show any diff.

Before
image

Now
image

Copy link

changeset-bot bot commented Aug 17, 2024

⚠️ No Changeset found

Latest commit: 3483131

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nicosampler nicosampler self-assigned this Aug 17, 2024
Copy link

nx-cloud bot commented Aug 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3483131. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@nicosampler nicosampler merged commit f56f44a into main Aug 20, 2024
7 of 9 checks passed
@nicosampler nicosampler deleted the feature/CAN-448 branch August 20, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants