Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove --fork-url and similar from build command #1290

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

dbeal-eth
Copy link
Contributor

users should always specify --rpc-url instead and let cannon do its thing

fixes https://linear.app/usecannon/issue/CAN-254/fork-url-is-not-being-taken-into-account-if-private-key-and-chain-id

note: should this also be removed from the cannon run command? I am trying to think of a case where --fork-url would be different from --rpc-url?

Copy link

changeset-bot bot commented Aug 18, 2024

⚠️ No Changeset found

Latest commit: 1301f28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1301f28. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@dbeal-eth dbeal-eth self-assigned this Aug 18, 2024
@dbeal-eth dbeal-eth added the bug Something isn't working label Aug 18, 2024
@dbeal-eth dbeal-eth changed the title remove --fork-url and similar from build command fix(cli): remove --fork-url and similar from build command Aug 19, 2024
@saeta-eth saeta-eth enabled auto-merge (squash) August 23, 2024 22:17
@saeta-eth saeta-eth merged commit 519a83f into main Aug 23, 2024
7 of 9 checks passed
@saeta-eth saeta-eth deleted the fork-handling branch August 23, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants