Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): CAN-374 stage TX with value #1302

Merged
merged 4 commits into from
Aug 21, 2024
Merged

fix(website): CAN-374 stage TX with value #1302

merged 4 commits into from
Aug 21, 2024

Conversation

nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Aug 20, 2024

Closes CAN-374.

Fixes an issue on interact section. When a tx was staged with a value like 2222^18 it was failing becuase the value (most of the times passed as string) was converted to Number instead of a BigInt.

Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: 7e496ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nicosampler nicosampler self-assigned this Aug 20, 2024
@nicosampler nicosampler requested a review from a team August 20, 2024 19:48
Copy link

nx-cloud bot commented Aug 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7e496ab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@nicosampler nicosampler added this pull request to the merge queue Aug 21, 2024
@saeta-eth saeta-eth removed this pull request from the merge queue due to a manual request Aug 21, 2024
@nicosampler nicosampler merged commit 295301a into main Aug 21, 2024
7 of 9 checks passed
@nicosampler nicosampler deleted the fix/CAN-374 branch August 21, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants