Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): Remove the throw error when the contract is already deployed #1327

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

saeta-eth
Copy link
Contributor

This change reverts some changes that make it difficult to deploy with CREATE2

Copy link

changeset-bot bot commented Aug 29, 2024

⚠️ No Changeset found

Latest commit: c814a52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saeta-eth saeta-eth requested a review from a team August 29, 2024 20:12
Copy link

nx-cloud bot commented Aug 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c814a52. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@saeta-eth saeta-eth merged commit 9ae399e into main Aug 29, 2024
7 of 9 checks passed
@saeta-eth saeta-eth deleted the fix/create2-bug branch August 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants