Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): CAN-479 - Refactor custom providers #1331

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Conversation

nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Aug 30, 2024

This PR closes CAN-479.
closes https://linear.app/usecannon/issue/CAN-473/ui-is-not-using-the-configured-providers-from-the-settings-page

I've converted the useProviders hook to a Provider which exposes useProviders.

Hopefully, this PR fixes the case of using custom providers not supported by viem.

@nicosampler nicosampler self-assigned this Aug 30, 2024
Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: 180aeb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9da2d0b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@nicosampler nicosampler marked this pull request as ready for review August 30, 2024 20:47
@nicosampler nicosampler marked this pull request as draft August 30, 2024 20:49
@nicosampler nicosampler marked this pull request as ready for review August 30, 2024 20:55
@dbeal-eth
Copy link
Contributor

@nicosampler please check if this PR replaces or should be in tandem or what with this PR #1330

@nicosampler
Copy link
Contributor Author

@nicosampler please check if this PR replaces or should be in tandem or what with this PR #1330

@dbeal-eth Ideally it should replace #1300, but I couldn't find the time yet if it works properly. Noah sent me a link to try to deploy to Snax.

@nicosampler nicosampler marked this pull request as ready for review September 4, 2024 19:24
@nicosampler nicosampler requested a review from a team September 4, 2024 19:24
Copy link
Member

@mjlescano mjlescano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjlescano mjlescano self-requested a review September 5, 2024 19:20
@mjlescano mjlescano merged commit d32b105 into main Sep 5, 2024
5 of 8 checks passed
@mjlescano mjlescano deleted the feature/CAN-479 branch September 5, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants