-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): CAN-479 - Refactor custom providers #1331
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9da2d0b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
@nicosampler please check if this PR replaces or should be in tandem or what with this PR #1330 |
@dbeal-eth Ideally it should replace #1300, but I couldn't find the time yet if it works properly. Noah sent me a link to try to deploy to Snax. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy page is not working with custom chains, e.g.: http://localhost:3000/deploy?chainId=2192&address=0xF5d66dC9B6963c61D7dacB1208145397cAc2e678
This PR closes CAN-479.
closes https://linear.app/usecannon/issue/CAN-473/ui-is-not-using-the-configured-providers-from-the-settings-page
I've converted the
useProviders
hook to a Provider which exposesuseProviders
.Hopefully, this PR fixes the case of using custom providers not supported by viem.