Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inspect): debug info #1352

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(inspect): debug info #1352

merged 1 commit into from
Sep 5, 2024

Conversation

mjlescano
Copy link
Member

@mjlescano mjlescano commented Sep 4, 2024

closes https://linear.app/usecannon/issue/CAN-457/cannon-inspect-has-an-extraneous-log

This PR makes sure that the build is not generating any extraneous logs when running cannon inspect --json, as the only expected output should be the JSON result.

Nevertheless, debug logs can still be used with:

DEBUG=cannon:cli:inspect dcannon inspect ...

Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: 1e0c114

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -10,6 +10,7 @@
"lint:fix:sol": "prettier --write '{packages,examples}/*/{contracts,src}/**/*.sol'",
"lint:fix": "pnpm run '/^lint:fix:(js|sol)/'",
"build": "pnpm -r --filter @usecannon/builder --filter @usecannon/cli --filter hardhat-cannon --filter @usecannon/api run build",
"watch": "pnpm -r --parallel --filter @usecannon/builder --filter @usecannon/cli run watch",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a helper script to be able to just run pnpm watch on the root, instead of having to open several tabs

@mjlescano mjlescano merged commit 68ab768 into main Sep 5, 2024
8 of 10 checks passed
@mjlescano mjlescano deleted the mock-inspect-log branch September 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants