fix(cli): settings lost their memoized values #1367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to memoize/cache the settings once they're used. In many parts of the code, we call resolveCliSettings without arguments, expecting it to return the memoized value. However, this isn't happening, and as a result, we're using incorrect settings. I've detected this issue in the decode command, but I'm fairly certain it's occurring throughout the project.
For instance,
cannon decode synthetix-omnibus:3.3.4@main 0x243fc3d98160ae6ec9f764dd688cbc4c99d29f30d5e28ebefdc4968a45371ce3 --rpc-url https://mainnet.gateway.tenderly.co
is not using the RPC url and instead its using the default Viem values.Closes https://linear.app/usecannon/issue/CAN-515/settings-lost-their-memoized-values