Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create2): allow to set ifExists = "continue" #1372

Merged
merged 2 commits into from
Sep 12, 2024
Merged

feat(create2): allow to set ifExists = "continue" #1372

merged 2 commits into from
Sep 12, 2024

Conversation

mjlescano
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 14ba9e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dbeal-eth
dbeal-eth requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential problem with this setup is that it doesn't allow for the simultaneous setting of the create2 contract address and the no strict option. It makes me feel like we need to have a separate arg all together

dbeal-eth
dbeal-eth approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more descriptive comment

packages/builder/src/schemas.ts Outdated Show resolved Hide resolved
packages/builder/src/steps/deploy.ts Outdated
@@ -278,7 +278,7 @@ const deploySpec = {
if (config.create2) {
const arachnidDeployerAddress = await ensureArachnidCreate2Exists(
runtime,
typeof config.create2 === 'string' ? (config.create2 as viem.Address) : ARACHNID_DEFAULT_DEPLOY_ADDR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the previous condition here was better

@mjlescano mjlescano force-pushed the add-create2-no-strict branch from fbf932d to 9309a9e Compare September 12, 2024 13:09
@mjlescano mjlescano changed the title feat(create2): allow to set no-strict check feat(create2): allow to set ifExists = "continue" Sep 12, 2024
@mjlescano mjlescano merged commit 2aa5448 into main Sep 12, 2024
6 of 8 checks passed
@mjlescano mjlescano deleted the add-create2-no-strict branch September 12, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FuzzB0t FuzzB0t FuzzB0t approved these changes

@dbeal-eth dbeal-eth dbeal-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjlescano @dbeal-eth @FuzzB0t