Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): protocol fallback #1384

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix(website): protocol fallback #1384

merged 2 commits into from
Sep 18, 2024

Conversation

mjlescano
Copy link
Member

This PR fixes an error on IPFS file fetch that made it not work when on https://usecannon.com because of the following restriction:
Screenshot 2024-09-17 at 10 01 38

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 22bcb13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nicosampler
Copy link
Contributor

It would be good to add a comment with all the combinations we support

@mjlescano mjlescano enabled auto-merge (squash) September 18, 2024 12:00
@mjlescano mjlescano merged commit 93cfd4e into dev Sep 18, 2024
6 of 8 checks passed
@mjlescano mjlescano deleted the fix-ipfs-protocol-fallback branch September 18, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants