Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): useSafeTransactionStatus also uses new safe abi #1397

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

saeta-eth
Copy link
Contributor

This PR addresses an issue with the useSafeTransactionStatus hook where transaction status was not being accurately determined. The hook has been updated to use the Safe 1.4.1 ABI to check transaction logs, ensuring accurate identification of transaction success or failure.

Closes https://linear.app/usecannon/issue/CAN-555/safe-status-check-is-not-working-on-newer-txs

@saeta-eth saeta-eth added the bug Something isn't working label Sep 19, 2024
@saeta-eth saeta-eth requested a review from a team September 19, 2024 16:53
@saeta-eth saeta-eth self-assigned this Sep 19, 2024
Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: 3741872

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saeta-eth saeta-eth merged commit 74bba6f into dev Sep 19, 2024
6 of 8 checks passed
@saeta-eth saeta-eth deleted the fix/safe-abi branch September 19, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants