Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): correct chain id handling in publish command when using package reference #1407

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

saeta-eth
Copy link
Contributor

@saeta-eth saeta-eth commented Sep 23, 2024

I introduced a bug – not yet released – where the publish command doesn't properly manage the chain ID when users provide a package reference and do not use the --chain-id flag.

Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: 93f26da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saeta-eth saeta-eth changed the title fix(cli): publish chain id when uses package ref fix(cli): correct chain id handling in publish command when using package reference Sep 23, 2024
@saeta-eth saeta-eth requested a review from mjlescano September 23, 2024 18:17
@saeta-eth saeta-eth merged commit 848d3c9 into dev Sep 23, 2024
8 of 10 checks passed
@saeta-eth saeta-eth deleted the fix/publish-chain-id branch September 23, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants