Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): chain id setup #1408

Merged
merged 9 commits into from
Sep 24, 2024
Merged

fix(publish): chain id setup #1408

merged 9 commits into from
Sep 24, 2024

Conversation

mjlescano
Copy link
Member

@mjlescano mjlescano commented Sep 23, 2024 •
edited
Loading

Closes https://linear.app/usecannon/issue/CAN-559/chainid-is-being-set-to-13370

This PR fixes two bugs:

  1. When running cannon publish including clone steps, it was wrongly publishing the subpackages with the 13370 chain instead of the target chain, that is addressed here: https://github.com/usecannon/cannon/pull/1408/files#diff-756d4c0d0bd036727ea6922554c95272acc0b2e94bd8311308f1a69574d94f82R98
  2. When running cannon build, the imports of clone steps were having always the chainId 13370, this is fixed here: https://github.com/usecannon/cannon/pull/1408/files#diff-950232bdec873b2ee3a9f82132b20b978b8ae9fcf3be3a475e613efee95046f6R256

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9e8c86a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mjlescano mjlescano requested a review from dbeal-eth September 24, 2024 01:29
dbeal-eth
dbeal-eth requested changes Sep 24, 2024
View reviewed changes
.nx/workspace-data/d/server-process.json Outdated
@@ -0,0 +1 @@
{"processId":63247}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

.nx/workspace-data/lockfile.hash Outdated
11580160284360395692
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

packages/builder/src/steps/clone.ts Outdated
@@ -253,7 +253,7 @@ const cloneSpec = {
state: builtState,
meta: deployInfo.meta,
status: partialDeploy ? 'partial' : 'complete',
chainId,
chainId: runtime.chainId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. clone steps should be pulling from chain ID 13370 by default. This is as intended. Please undo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was correct. It will be included in v2.18.0.

@dbeal-eth dbeal-eth enabled auto-merge (squash) September 24, 2024 03:57
@dbeal-eth
Copy link
Contributor

fix confirmed, going to merge this as is.

@dbeal-eth dbeal-eth merged commit 4cd7879 into main Sep 24, 2024
6 of 8 checks passed
@dbeal-eth dbeal-eth deleted the hotfix/build-chain-id branch September 24, 2024 04:05
@mjlescano mjlescano mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saeta-eth saeta-eth saeta-eth left review comments

@FuzzB0t FuzzB0t FuzzB0t approved these changes

@dbeal-eth dbeal-eth dbeal-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjlescano @dbeal-eth @saeta-eth @FuzzB0t