Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add snaxchain color #1419

Merged
merged 2 commits into from
Oct 2, 2024
Merged

feat(website): add snaxchain color #1419

merged 2 commits into from
Oct 2, 2024

Conversation

noahlitvin
Copy link
Member

@noahlitvin noahlitvin commented Sep 30, 2024

Screenshot 2024-09-29 at 9 37 56 PM

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: ba223fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saeta-eth
Copy link
Contributor

saeta-eth commented Oct 1, 2024

@noahlitvin There is a small issue:

./src/providers/CannonProvidersProvider.tsx:85:11
Type error: Property 'snax' does not exist on type 'typeof import("/home/runner/work/cannon/cannon/node_modules/.pnpm/viem@2.16.5_bufferutil@4.0.8_typescript@5.5.4_utf-8-validate@5.0.10_zod@3.23.8/node_modules/viem/_types/chains/index")'.

  83 |     color: '#04f06a',
  84 |   },
> 85 |   [chains.snax.id]: {
     |           ^
  86 |     color: '#00D1FF',
  87 |   },

@noahlitvin
Copy link
Member Author

How are these types generated?

@saeta-eth
Copy link
Contributor

How are these types generated?

Looks like Viem was updated to the latest version on the main branch and that's why it didn't find the snax chain. Once we rebase the branch it should work fine.

@saeta-eth saeta-eth merged commit c922ef1 into dev Oct 2, 2024
8 of 10 checks passed
@saeta-eth saeta-eth deleted the snax-chain-color branch October 2, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants