We love pull requests from everyone. By participating in this project, you agree to abide by the CODE_OF_CONDUCT.md
Fork, then clone the repo:
git clone git@github.com:your-username/json_logic_ruby.git
Set up your machine:
bundle install
Make sure the tests pass:
rspec
Make your change. Add tests for your change. Make the tests pass:
rspec
Push to your fork and submit a pull request.
At this point you're waiting on us. We like to at least comment on pull requests within three business days (and, typically, one business day). We may suggest some changes or improvements or alternatives.
Some things that will increase the chance that your pull request is accepted:
- Write tests.
- Write a good commit message, using also release-please approach
- Make changes to code (make sure to create correct commits with release-please approach)
- Update version in
lib/json_logic/version.rb
- Create PR with changes
- After PR is merged, release-please will create new PR
- Merge the final PR