CronJob API version update to batch/v1

[britslampe]

build-deploy-tool/legacy/helmcharts/cli/templates/cronjob.yaml

Line 3 in a0a2b34

apiVersion: batch/v1beta1

The apiVersion for CronJobs in legacy/helmcharts/cli/templates/cronjob.yaml references the depreciated batch/v1beta1 version, which is no longer supported in v1.22+. Requesting an update to switch to using batch/v1 that is supported in active and maintained Kubernetes versions.

[britslampe]

Adding reference to the cronjob.yaml in basic/templates/cronjob.yaml in https://github.com/uselagoon/build-deploy-tool/blob/main/legacy/helmcharts/basic/templates/cronjob.yaml

[shreddedbacon]

Will discuss with the team, but v1beta1 is available until kubernetes 1.25 https://kubernetes.io/docs/reference/using-api/deprecation-guide/#cronjob-v125

Since v1 was introduced in kubernetes 1.21, we need to do some changes and make sure people are running 1.21+ before we can change this.

[tobybellwood]

Lagoon v2.12.x (released in Jan 2023) will support a minimum Kubernetes version of 1.21, so this change will be introduced then. For anyone needing backwards compatibility after that point 😱, they can always fork and add a semver comparison in there

{{- if semverCompare ">=1.21-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: batch/v1
{{- else -}}
apiVersion: batch/v1beta1
{{- end }}