Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settle config load order of precedence #65

Closed
bomoko opened this issue Aug 23, 2022 · 2 comments
Closed

Settle config load order of precedence #65

bomoko opened this issue Aug 23, 2022 · 2 comments

Comments

@bomoko
Copy link
Collaborator

bomoko commented Aug 23, 2022

There seems to be some weirdness with the order that config files are loaded.

If I pass a config file into lagoon-sync, I expect that config to be the one that's used before every other possibility.

We need to settle this order to something like

1 - if config is passed as argument, it's used
2 - any local (to the project) .lagoon.yml (if the lagoon-sync section appears)
2 - Anything set in the LAGOON_SYNC_DEFAULTS_PATH and LAGOON_SYNC_PATH env var
3 - eventually - fall back on default to the app itself.

The relevant code seems to be here https://github.com/uselagoon/lagoon-sync/blob/main/cmd/root.go#L60-L121

@timclifford
Copy link
Contributor

timclifford commented Jun 7, 2023

I cansee this work has been partly started in #66

@timclifford
Copy link
Contributor

This one got tackled in #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants