Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing "Results to display" causes a full page refresh #41

Closed
rocketeerbkw opened this issue Sep 29, 2022 · 1 comment
Closed

Changing "Results to display" causes a full page refresh #41

rocketeerbkw opened this issue Sep 29, 2022 · 1 comment

Comments

@rocketeerbkw
Copy link
Member

Currently when a user changes the number of results to display on a page (Backups, Deployments, and Tasks), the component calls window.location with the new results which causes a full page refresh.

But we're using React which means we should be able to update the data inline.

A potential fix would be to change the ResultsLimited component that instead of having an internal onChange event, it accepts an onChange function as part of its props. Then each page that that uses the component can handle it's own state.

@DaveDarsa
Copy link
Contributor

fixed in #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants