Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some changes and improvements alongside bugfixes #158

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Conversation

DaveDarsa
Copy link
Contributor

This PR does the following:

  • fixes numeric sort in a couple places using <PaginatedTable/>
  • adds "sort-by-role" functionality on the users page
  • changes deletion modal texts to be accurate
  • modals understand where the user is being updated or added
  • users table has a "show/hide default users" filter
  • each table now shows their row at their headers
  • Adds project links to organization projects
  • adds loading/disabled indicator to action buttons to avoid repeated mutations
  • fixes group -> user link
  • and some smaller issues

@DaveDarsa
Copy link
Contributor Author

@tobybellwood the issue with number of users shown on the Users page and the Group page is there because usersByOrganization and groupByNameAndOrganization queries return users that are different.

</ProjectGroupLink>

<ProjectLink projectSlug={project.name} key={project.id}>
<ProjectRoute>ROUTE</ProjectRoute>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically these aren't project routes - maybe ProjectDashboard would be better - and maybe opening in a new tab by default?

Suggested change
<ProjectRoute>ROUTE</ProjectRoute>
<ProjectRoute>View in Dashboard</ProjectRoute>

@DaveDarsa
Copy link
Contributor Author

  • <ProjectDashboard/> opens a new tab to project dashboard
  • Table counters fixed ( shows all item count, or searchString-filtered item count)
  • Default user / System group tags added where missing previously

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh - looking good now!

@tobybellwood tobybellwood merged commit 9a62778 into main Sep 10, 2023
@tobybellwood tobybellwood deleted the various-changes branch September 10, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants