Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include error handling for New Environment functionality #175

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Include error handling for New Environment functionality #175

merged 1 commit into from
Oct 12, 2023

Conversation

CGoodwin90
Copy link
Contributor

Adds a error notification if the deployEnvironmentBranch mutation returns Skipped: configured regex for all deploytargets does not match branchname.

image

@CGoodwin90 CGoodwin90 marked this pull request as ready for review October 12, 2023 05:30
tobybellwood
tobybellwood approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy with this

@tobybellwood tobybellwood merged commit d12f5dd into main Oct 12, 2023
2 checks passed
@tobybellwood tobybellwood deleted the new_env_error_handling branch October 12, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGoodwin90 @tobybellwood