Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a project-level router pattern #2791

Closed
twardnw opened this issue Jul 28, 2021 · 4 comments · Fixed by #2806
Closed

implement a project-level router pattern #2791

twardnw opened this issue Jul 28, 2021 · 4 comments · Fixed by #2806
Labels
2-build-deploy Build & Deploy subsystem enhancement

Comments

@twardnw
Copy link
Contributor

twardnw commented Jul 28, 2021

It would be super handy for some clients that have a managed CDN to be able to set up a project level router pattern. This would ideally live as a project level setting in the API.

@twardnw twardnw added 2-build-deploy Build & Deploy subsystem enhancement labels Jul 28, 2021
@shreddedbacon
Copy link
Member

shreddedbacon commented Aug 9, 2021

Currently we inject the openshift/kubernetes scoped routerPattern into the build spec here: https://github.com/uselagoon/lagoon/blob/main/node-packages/commons/src/tasks.ts#L303

What you could do is add a new field to the project type that is routerPattern. Then just update the logic in tasks.ts to check if a project routerPattern has been defined, and inject that instead.

EDIT: The build-deploy controller turns that into the ROUTER_URL that kubectl-build-deploy-dind uses here https://github.com/amazeeio/lagoon-kbd/blob/main/controllers/lagoonbuild_controller.go#L355-L370

@tobybellwood
Copy link
Member

ALso #2573 #2574 and #2666 probably relevant here if we're looking at router patterns

@smlx
Copy link
Member

smlx commented Aug 10, 2021

What if we just have router-logs-* as the only pattern, and then you can filter by lagoon.sh/project label?

edit: wrong thing, sorry for the noise

@shreddedbacon
Copy link
Member

What if we just have router-logs-* as the only pattern, and then you can filter by lagoon.sh/project label?

I think that is a different issue, this pattern is for customising autogenerated routes router patterns that are used when creating the ingress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-build-deploy Build & Deploy subsystem enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants