Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the sql-sync and rsync drush tasks fail on non git-safe branch names #2911

Open
tobybellwood opened this issue Nov 4, 2021 · 2 comments
Open

Comments

@tobybellwood
Copy link
Member

The drush sync tasks use sourceEnvironment.name to populate the source environment command from the UI.

if this environment contains a period (.) then it is not transposed into the hyphenated (-) version required by drush aliases.

We would need to safetyify this input in the UI if possible. Not sure whether this has always been the case?

e.g.

[drupal-example-simple]9.x-test6-2@cli-drupal:/app$ drush la
@lagoon.drupal-example-simple-9-x-test6-1 (production)
@lagoon.drupal-example-simple-9-x-test6-2
@rocketeerbkw
Copy link
Member

Also an issue with slashes (/) in branch name like feature/1111-new-feature or bug/2222-thing-broken

@tnelson-doghouse
Copy link

This is also affecting us, for the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants