Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Billing Code from API #2837

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Removing Billing Code from API #2837

merged 5 commits into from
Jan 26, 2022

Conversation

justinlevi
Copy link
Contributor

related:

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

This PR removes all billing related code from the API in favor of an external proprietary solution.

Closing issues

closes #2687

@justinlevi
Copy link
Contributor Author

@rocketeerbkw Could you take a look at this one?

@rocketeerbkw rocketeerbkw self-requested a review October 13, 2021 19:48
rocketeerbkw
rocketeerbkw requested changes Oct 13, 2021
View reviewed changes
node-packages/commons/src/tasks.ts Outdated Show resolved Hide resolved
services/api-db/docker-entrypoint-initdb.d/01-migrations.sql Show resolved Hide resolved
services/api/src/models/group.ts Outdated Show resolved Hide resolved
services/api/src/resolvers.js Outdated Show resolved Hide resolved
services/api/src/typeDefs.js Outdated Show resolved Hide resolved
services/keycloak/start.sh Show resolved Hide resolved
@tobybellwood tobybellwood added this to the v2.x milestone Oct 13, 2021
@tobybellwood tobybellwood modified the milestones: v2.x, v2.4.0 Nov 22, 2021
@rocketeerbkw rocketeerbkw force-pushed the feature/LAGOON-23-Migrate-Billing-Code-From-API branch from 24ddee0 to 9d4fedf Compare January 26, 2022 12:54
rocketeerbkw
rocketeerbkw approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@rocketeerbkw rocketeerbkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on main, resolved change requests, tested against a prod dataset.

@tobybellwood tobybellwood merged commit b42cc58 into uselagoon:main Jan 26, 2022
@seanhamlin seanhamlin mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketeerbkw rocketeerbkw rocketeerbkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@justinlevi @rocketeerbkw @tobybellwood