Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare DeployTargetConfig related api fields as unstable #2877

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

rocketeerbkw
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

The GraphQL spec includes an @deprecated directive. All the dev tools I've tried are aware of this directive and will surface it in an explicit way. I think this would be a nicer way to warn users that the API is unstable.

Cons: it's maybe not correct to call it "deprecated" instead of unstable/alpha, but then all the dev tools wouldn't show that info.

Examples from dev tools:

Insomnia.app
Fullscreen_10_18_21__5_51_PM

GraphiQL
Fullscreen_10_18_21__6_07_PM

GraphQL Playground
Fullscreen_10_18_21__6_10_PM

Closing issues

n/a

@rocketeerbkw rocketeerbkw added the 1-api-auth API & Authentication subsystem label Oct 18, 2021
@rocketeerbkw rocketeerbkw added this to the v2.x milestone Oct 18, 2021
@rocketeerbkw rocketeerbkw marked this pull request as ready for review October 19, 2021 06:06
@tobybellwood tobybellwood merged commit 50b4d59 into main Oct 19, 2021
@tobybellwood tobybellwood deleted the deprecate-deploytargets branch December 22, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-api-auth API & Authentication subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants