Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds image cache images to build #2919

Merged
merged 5 commits into from
Nov 25, 2021

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Nov 8, 2021

This PR introduces a new set of build args made available to the present build that give precise reference to the images rolled out in the last deployment.

It interrogates the current deployment list and introduces build args LAGOON_CACHE_{service name} for each service.
The service name is drawn by matching any images in the deployment with the standard structure harborbase/{project}/{environment}/{service}/....

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

Details for what issue this solves are described in the linked issue

Closing issues

closes #2918

@tobybellwood
Copy link
Member

maybe we can get a brief para in the docs about this too
https://docs.lagoon.sh/lagoon/using-lagoon-the-basics/build-and-deploy-process#3.-build-image

@bomoko
Copy link
Contributor Author

bomoko commented Nov 8, 2021

100% @tobybellwood - I think that once we've done some testing and tweaking on the test cluster, I'll do a writeup.

@bryangruneberg
Copy link
Contributor

yes! this is nice

@tobybellwood tobybellwood added this to the v2.4.0 milestone Nov 22, 2021
@bomoko bomoko marked this pull request as ready for review November 23, 2021 21:52
@tobybellwood
Copy link
Member

We need a test, and some docs for this, ping @bomoko to follow up

@tobybellwood tobybellwood merged commit a9c34ec into uselagoon:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds should have access to previous builds' images
3 participants