Passing no-tablespaces flag into drush sql-dump for task

[timclifford]

Checklist

• Affected Issues have been mentioned in the Closing issues section
• Documentation has been written/updated
• PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

[tobybellwood]

ok (another comment incoming about the drush version command) but broadly this works on Drush9/10

in Drush 8, the issues in drush-ops/drush#4489 arise, namely that whilst the dump works, it doesn't truncate the cache or watchdog tables, resulting in a potentially enormous backup.

Will continue digging

[tobybellwood]

so, to replicate the truncating of a "common" structure-tables-list
$command_specific['sql-dump'] = array('structure-tables-list' => 'cache,cache_*,history,sessions,watchdog,feeds_log');

drush sql-dump --extra=--no-tablespaces | grep -Ev 'INSERT INTO `(cache|cache_|history|sessions|watchdog|feeds_log)' | gzip > $file.gz

or similar via awk (fewer matches for brevity)

drush sql-dump --extra=--no-tablespaces | awk '!/INSERT INTO `cache_ && !/INSERT INTO `watchdog' | gzip > $file.gz

The question is - do we want to define which tables aren't dumped for customers....

[tobybellwood]

ok - going to press ahead with this - large dumps are better than broken dumps.