Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted OpenDistro and OpenSearch fixes #3017

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Conversation

tobybellwood
Copy link
Member

This PR does the following:

  • adds rejectUnauthorized: false to the got commands to interact with Kibana and OpenDistro/Opensearch security - Whilst the elasticsearch plugin can handle the varied authentication, got can't - so we need this. Given this comminication is within the cluster, and to endpoints defined within the API service, the risk of setting this is minimal
  • adds the 'osd-xsrf': 'true' header to the kibanaClient to handle OpenSearch Dashboards, as well as Kibana
  • adds indices:monitor/settings/get to intial index permissions for groups to enable reporting

@tobybellwood tobybellwood requested a review from smlx February 8, 2022 03:21
Copy link
Member

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way to test this, but LGTM otherwise. Also goes some way towards fixing #2844

local-dev/lagoon-logging.values.yaml Outdated Show resolved Hide resolved
@@ -45,7 +45,7 @@ export const OpendistroSecurityOperations = (
index_permissions: [
{
index_patterns: [],
allowed_actions: ['read']
allowed_actions: ['read','indices:monitor/settings/get']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change allow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the core permissions required to add reporting access to user accounts in ODFE. Without this permissions, it appears that users are unable to select the data needed to create reports.

@tobybellwood tobybellwood merged commit d869a8b into main Feb 9, 2022
@tobybellwood tobybellwood deleted the odfe_opensearch_logs branch February 9, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants