Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrap sbom generation in feature flag #3028

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

This wraps the SBOM step in a feature flag so that it can be enabled/disabled as required

@shreddedbacon
Copy link
Member Author

shreddedbacon commented Feb 14, 2022

The flag to add to the project or environments variables would be LAGOON_FEATURE_FLAG_INSIGHTS

Support will be added to remote-controller to inject this with a default value using the feature flag logic already built in

Co-authored-by: Toby Bellwood <toby.bellwood@amazee.io>
@shreddedbacon shreddedbacon merged commit 1adc1a7 into main Feb 14, 2022
@shreddedbacon shreddedbacon deleted the feature-flag-sbom branch February 14, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants