Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle symlink to charts directory other than a local subdirectory #3043

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

smlx
Copy link
Member

@smlx smlx commented Feb 21, 2022

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Part of my development workflow is to point the charts directory symlink used by make kind/retest at a local charts directory that is outside of my lagoon working directory. Currently that doesn't work.

This change allows kind/retest to follow that symlink even if it is not pointing at a subdirectory of the lagoon working directory.

If the charts symlink is pointing somewhere other than a subdirectory of
the local lagoon working tree then readlink gets confused. The problem
is described here, which is also where I got the solution:
https://superuser.com/a/1217241

Closing issues

n/a

If the charts symlink is pointing somewhere other than a subdirectory of
the local lagoon working tree then readlink gets confused. The problem
is described here, which is also where I got the solution:
https://superuser.com/a/1217241
@smlx smlx added the 6-images-testing Base Images & Testing subsystem label Feb 21, 2022
@smlx smlx requested a review from tobybellwood February 21, 2022 14:20
@tobybellwood tobybellwood merged commit f14c08b into main Feb 21, 2022
@tobybellwood tobybellwood deleted the charts-symlink branch February 21, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants