fix: improve rootless migration logic #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves handling of the case where a Lagoon environment running as root has changed the ownership and permissions of files in their shared storage volume by rsyncing from another location, and then switched to rootless. It should now be the case that no matter how the ownership/permissions have been changed, enabling rootless for the environment will normalise the filesystem correctly for the rootless workload to have full access. This change has been tested across three managed Kubernetes vendors (EKS, GKE, AKS). See: https://github.com/amazeeio/rootless-migration-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR improves handling of the case where a Lagoon environment running
as root has changed the ownership and permissions of files in their
shared storage volume by rsyncing from another location, and then
switched to rootless.
It should now be the case that no matter how the ownership/permissions
have been changed, enabling rootless for the environment will normalise
the filesystem correctly for the rootless workload to have full access.
This change has been tested across three managed Kubernetes vendors
(EKS, GKE, AKS).
See: https://github.com/amazeeio/rootless-migration-tests
Closing issues
Closes: #3044