Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fact summary functionality to environment fact resolver #3063

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

bomoko
Copy link
Contributor

@bomoko bomoko commented Mar 14, 2022

This PR adds a a summary option to environment fact details.

Essentially, calling a query like the following

query allp {
  allProjects {
    name
    environments {
      name
      facts(summary:true) {
        id
        name
        source
        category
        description
      }
    }
  }
}

Will reduce duplicate facts -- where duplicates are considered those facts with identical names, values, and descriptions as being identical -- to single entries. source fields are, further, summarized into a single comma separated value. Unique fields such as id and created are made null, since in the context of summaries they make little sense.

@bomoko bomoko changed the title Feature/key fact aggregation Adds fact summary functionality to environment fact resolver Mar 14, 2022
@bomoko bomoko requested a review from tobybellwood March 14, 2022 00:35
@tobybellwood tobybellwood merged commit b9bb785 into main Mar 15, 2022
@tobybellwood tobybellwood deleted the feature/key_fact_aggregation branch March 15, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants