Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up task logs for environment names with slash in the name #3068

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Currently if an environment has / in the name or is too long, the task logs may not be retrievable.

This adds the name shortening and making safe the environment name to match how they are stored in the bucket correctly

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@tobybellwood tobybellwood merged commit 94324ba into main Mar 16, 2022
@tobybellwood tobybellwood deleted the environment-name-logs2s3 branch March 16, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants