add rootless rsync commands to drush rsync task #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With rootless systems running a normal `drush rsync` command causes some issues as rootless systems (like openshift or k8s rootless) do not allow the executing user to do some of the standard things that rsync wants to do (change owner and group to what the source had). Therefore we tell `drush rsync` to run `rsync` with some additional parameters that will prevent it to fail
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rootless systems running a normal
drush rsynccommand causes some issues as rootless systems (like openshift or k8s rootless) do not allow the executing user to do some of the standard things that rsync wants to do (change owner and group to what the source had).Therefore we tell
drush rsyncto runrsyncwith some additional parameters that will prevent it to failThis is also documented here: https://docs.lagoon.sh/drupal/drush-9/#drush-rsync-from-local-to-remote-environments
Checklist
Explain the details for making this change. What existing problem does the pull request solve?
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).