Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add group-lagoon-project-ids to project-default groups #3166

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

smlx
Copy link
Member

@smlx smlx commented Jun 2, 2022

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

This annotation is required for the ssh-portal service to determine
permissions for users which have permissions on a project through a
project-default group.

Closing issues

n/a

This annotation is required for the ssh-portal service to determine
permissions for users which have permissions on a project through a
project-default group.
@smlx smlx added the 1-api-auth API & Authentication subsystem label Jun 2, 2022
@smlx
Copy link
Member Author

smlx commented Jun 2, 2022

I haven't got a test case for this but manually checking the group annotations shows it is working:
Screenshot from 2022-06-02 14-16-04
Regular group for comparison:
Screenshot from 2022-06-02 14-16-31

@smlx smlx requested a review from rocketeerbkw June 2, 2022 06:18
@tobybellwood tobybellwood merged commit 0653c15 into main Jun 3, 2022
@tobybellwood tobybellwood deleted the project-default-group-annotation branch June 3, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-api-auth API & Authentication subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants