Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: active/standby support for environments with slash in the name #3214

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

As #3212 describes, if a production or standby production environment have slashes in their names, they don't work correctly with active/standby. This refactors the activestandby switch to first check environments that don't have slashes, if this fails it checks all environments for the project to try and find the environment with the name that is made safe.

Closing issues

closes #3212

@shreddedbacon shreddedbacon changed the title feat: export makesafe function Fix active/standby support for environments with slash in the name Jul 15, 2022
@shreddedbacon shreddedbacon marked this pull request as ready for review July 15, 2022 06:29
@shreddedbacon shreddedbacon changed the title Fix active/standby support for environments with slash in the name Fix: active/standby support for environments with slash in the name Jul 27, 2022
@tobybellwood tobybellwood merged commit 529a78d into main Sep 6, 2022
@tobybellwood tobybellwood deleted the activestandby-branchnames branch September 6, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch names with slash don't work in active/standby
2 participants