Skip to content
This repository has been archived by the owner on May 16, 2022. It is now read-only.

updates to creating a release PR #148

Open
5 tasks
TomasTomecek opened this issue Feb 18, 2019 · 4 comments
Open
5 tasks

updates to creating a release PR #148

TomasTomecek opened this issue Feb 18, 2019 · 4 comments
Labels
feature New feature or a request for enhancement.

Comments

@TomasTomecek
Copy link
Member

TomasTomecek commented Feb 18, 2019

TODO

  • don't create duplicate commits in case of failures (in packit/ogr, bot was not allowed to create a PR and kept adding new commits; we should reset --hard upstream/master before starting adding new commits)
  • ditch our github client implementation for packit/ogr
  • fork the repo and create the PR from fork
  • remove branches once they are merged
  • create changelog.md if it's not present (should be configurable)
@TomasTomecek TomasTomecek changed the title updates to creating release PR updates to creating a release PR Feb 18, 2019
@lachmanfrantisek
Copy link
Member

What about creating the CHANGELOG.md if the file does not exist?

@TomasTomecek
Copy link
Member Author

could you elaborate please?

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Feb 18, 2019

could you elaborate please?

Is CHANGELOG.md already present?

  • NO -> Create the file and add the changes for the current release.
  • YES -> Add new changes on top of the file as usual. (already implemented)

@TomasTomecek
Copy link
Member Author

I added one more entry to the list, let me know if that's what you meant, because r-bot is already doing the YES branch afaik

@TomasTomecek TomasTomecek added the feature New feature or a request for enhancement. label Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or a request for enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants