-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement html color-scheme meta tag and remove custom scrollbar #59
Comments
You forgot a tiny little detail: browser compatibility. Scroll down a bit & see that none of the variants work on more than 90% of all devices. |
besides the fact that I'm very sceptical of handing the responsibility of styling elements down to the system. |
There is 2 things here, Quite frankly the one Riedler has pointed.
^^ So that means that Chromium/Safari get's to see a mixed dark mode and we somehow have to resolve around the problem with other CSS engines to not be affected by this. I really love new inventions and that such things actually get standardized instead of just pushing it down to users/developers to adopt to, but it's at the moment not possible to have this implemented well holding compatibility. |
We talked about this on the Discord, but I just want to let you know that this issue request is not anything you are suggesting. Using this option to let the browser know the website supports dark mode changes the default UA styling, it does not override any of the existing styling. As this website already has its own styling the only elements this change would affect, would be the native input elements like I mentioned such as checkboxes, dropdowns, and scrollbars. The only potential compatibility issue is that users on old versions of Chromium would get white scrollbars instead of the website's custom scrollbar. Use GitHub for example, they already support this feature and it's a non-issue. |
This feature has 84% browser support. The other variants that you mentioned are deprecated, which you may have been unaware of. |
That's still the same problem I see, why partially let the system handle this and the other half let us style it with other non-color properties.
It was rather a draft change, it seems like scrollbar wasn't originally covered in the css-color-adjust-1 and was still up to discussion so far I can see the history of the document with chromium source code. As it's still a draft and any comparability can change any time and chromium don't hassle to just remove the old behavior. I can implement it for now and see how things settle, but if causing me to write workarounds for workarounds the thing will get removed and Il let this draft get to a level-1 version before considering things again. Regards, |
See, 9953239 in it will be working in combination of the upcoming user settings. |
@Gusted I'm going to reopen it and have it close automatically once changes are merged and live in production. |
Describe the change you'd like:
Order of
dark light
means that dark is default if no theme is detected, the same as how theprefers-color-scheme
CSS is currently set up.Additional context:
https://web.dev/color-scheme/
The text was updated successfully, but these errors were encountered: