Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yop project for latest VScode release #434

Open
jurgenvinju opened this issue Aug 30, 2024 · 4 comments
Open

fix yop project for latest VScode release #434

jurgenvinju opened this issue Aug 30, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jurgenvinju
Copy link
Member

Describe the bug

image

This does not break the code, but since we have ultimate beginners looking at these files, it could be confusing to read the new (otherwise very helpful) message.

@jurgenvinju jurgenvinju added the bug Something isn't working label Aug 30, 2024
@jurgenvinju jurgenvinju self-assigned this Aug 30, 2024
@DavyLandman DavyLandman added documentation Improvements or additions to documentation and removed bug Something isn't working labels Aug 30, 2024
@DavyLandman
Copy link
Member

I don't think this is a VS Code bug right? Looks more like a specific example project that needs to be updated?

@jurgenvinju
Copy link
Member Author

I posted it here to signal that we may have some (important) downstream projects that are now broken with the latest VScode extension without us realizing it. This one has hundreds of users, for example.

Is a missing pom.xml file really breaking the extension? I think we might need a softer message for a missing pom file, as compared to a missing RASCAL.MF file.

@DavyLandman
Copy link
Member

It's already a warning, but yes, if you are missing a pom.xml, some of your dependencies might not be picked up. (like say you did edit your rascal.mf to have a dependency).

Can we make better diagnostics? Yes. I would also ideally like us to have a quickfix for the problems we know how to fix..

@DavyLandman
Copy link
Member

@jurgenvinju I think the latest fixes to the validators fixed this, can you make sure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants