Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter modal footer obscures some elements #1994

Closed
gitudaniel opened this issue Aug 8, 2017 · 7 comments · Fixed by ushahidi/platform-pattern-library#244
Closed

Filter modal footer obscures some elements #1994

gitudaniel opened this issue Aug 8, 2017 · 7 comments · Fixed by ushahidi/platform-pattern-library#244

Comments

@gitudaniel
Copy link

gitudaniel commented Aug 8, 2017

Expected behaviour

All fields should be visible and clickable

Actual behaviour

Some fields in the filters dropdown are barely visible and not clickable.

Steps to reproduce the behaviour/error

Go to the Ushahidi platform client, click on filters and scroll down. You will see something like this
Screenshot from 2020-10-08 14-00-07

Instead, the dropdown footer should come after the fields, not on top of them
Aha! Link: https://ushahiditeam.aha.io/features/PROD-539

@rjmackay rjmackay added the Bug label Nov 3, 2017
@zube zube bot removed the Backlog label Jan 29, 2018
@jshorland jshorland added this to the UX clean up milestone Feb 28, 2018
@rowasc rowasc removed this from the UX clean up milestone Sep 13, 2018
@rowasc rowasc added Community Task Issues that the Ushahidi OSS community is encouraged to contribute to Theme: Filters & Search labels Jun 18, 2019
@rowasc rowasc added this to the Parking Lot milestone Sep 4, 2020
@onyeepeace
Copy link

Hello @rowasc, what needs to be done with this? I am an Outreachy intern and I will like to work on it. I opened up uchaguzi.or.ke on firefox in windows and the radio buttons are clickable. Was it fixed previously or it has a different problem?

@rowasc
Copy link
Contributor

rowasc commented Oct 8, 2020

Hey. I just edited the description to make it more generally applicable. Does it make sense now? (Thanks for letting us know)
cc @Angamanga tagging Anna for follow up about any specific implementation details

@rowasc rowasc modified the milestones: Parking Lot, Hacktoberfest Oct 8, 2020
@rowasc rowasc added Outreachy and removed Community Task Issues that the Ushahidi OSS community is encouraged to contribute to labels Oct 8, 2020
@onyeepeace
Copy link

Yes, it is clear now. I will reach out if I need anything again.

@onyeepeace
Copy link

onyeepeace commented Oct 11, 2020

@Angamanga @rowasc I am in need of some help. How do I access the css file for this issue. I could inspect it in my browser and I have seen what's wrong. I am now stuck at working on the css file. The css file that points to it is in the node modules. I know I shouldn't edit the node modules. Do I create a css file to target the issue? or what do I do? Please I need some help.

@onyeepeace
Copy link

@Angamanga @rowasc I have made a pull request on the platform-pattern-library ushahidi/platform-pattern-library#244 to fix this issue. Please kindly review. Thanks.

@Angamanga
Copy link
Contributor

@onyeepeace Thank you! I will review shortly!

@onyeepeace
Copy link

@Angamanga Okay, great. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment