-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weak color contrast and issues for tab key users in the map and search area of the map page. #4119
Weak color contrast and issues for tab key users in the map and search area of the map page. #4119
Comments
@Angamanga The thing is I only edited the code for issue #4115 #4116 in the dev tool and not in the actual code base. I found that some of the Issues also happens on the map and search area of the page. I suggest that since @siggrid found the other issue first & since she has started work on it, then let me work on this issue I just raised instead. Waiting to hear your verdict. |
@Ifycode Yes, I'll assign you to this issue. We need to make this change in the pattern library and also make sure we identify all places in the platform where it would be needed. Which colors do you suggest to use? Would they work generally over the platform? |
Ok. Great. Thank you! Hmm... Identify all the places in the platform... That's true. About the color, I suggest that the dark yellow color used on the save search button and the round button should be used for uniformity since it's one of the major colors all over the site. I left some messages (observations & questions) on Issue #4044 for you too. Please check @Angamanga @rowasc |
I found the color on the button is what is used for the box-shadow. The dark yellow doesn't look great on its own if box-shadow is increased. |
oh ok. Yeah I think we should go with this as an initial fix, sharp edges are better than the low contrast situation we have right now IMO. It's progress. |
Ok. Makes sense! Thanks. I'll get to work then. |
Hey @Ifycode |
@siggrid Yes I'm working on making the outline more visible when using the tab key (and fix skipped elements - if any). Maybe you can give more detail about what you've done or send a link to the PR for the fixes you made? So I can ensure we aren't tweaking same things. Thanks. |
@Ifycode Hope, it is not too late. |
No it's not. Thank you @siggrid |
Description:
Additional findings:
Steps to reproduce the behaviour:
Aha! Link: https://ushahiditeam.aha.io/features/PROD-871
The text was updated successfully, but these errors were encountered: